On Mon, Nov 07, 2005 at 11:59:21PM +0100, Ulf Lilleengen wrote: > On Tue, Nov 01, 2005 at 02:58:48PM -0800, Brooks Davis wrote: > > On Tue, Nov 01, 2005 at 04:30:00PM -0600, Ben Siemon wrote: > > > I have a suggestion for things dev people could do to help out with > > > code already done. I noticed the suggestion for compiling with -Wall > > > enabled. Would it serve any purpose to compile the sources with -ansi > > > and or -pedantic as well? I am fairly new to FreeBSD so forgive me if > > > this has alread been addressed. > > > > I think the todo list is dated in this area. We now compile many files > > with large sets of warning flags via the WARNS variable in Makefiles. > > It is useful to expand the coverage in this area, but it's not all that > > trivial. It's often fairly easy to make the warning go away without > > fixing the real problem the warning represented. This means that far > > too many patches to raise warning levels are useless and waste developer > > time. There's also the fact that such changes need to be tested on > > multiple architectures because certain warnings are platform specfic. > > At the least testing is needed on i386, alpha, and sparc. > > > I've seen an effort to remove these warnings by setting WARNS?=6 . Would > this be preferable to work on, on freebsd as well? Ofcourse testing on > most architectures.
Setting WARNS= higher and fixing the warning is useful, but we've see a lot of submissions that took more time to fix than dealing with the problem would have in the first place. The work of someone who submitted high-quality fixes consistantly, would certainly be appreciated. -- Brooks -- Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4
pgpmO8AfnHWTI.pgp
Description: PGP signature
