In message <[EMAIL PROTECTED]>, Ian Dowse writes: >I don't think this is necessary, because the cleanup code at the >end of nfsrv_mknod() catches any cases where nd.ni_vp was not >released earlier. It would be harmless to add it though.
Oops, I missed a 'return (0);' when reading the code. You're quite correct here; the first part of the patch looks correct, and could certainly cause vput's to be forgotten. I'll try to reproduce this now. It's just the vp == dvp stuff that is ok as it is. Ian To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-hackers" in the body of the message