The code of usr.sbin/ac/ includes support for handling ":0.0" as
console logins, when CONSOLE_TTY is defined during compilation.
Looking at the code, and revisions from 1.2 and up, this doesn't seem
to be used.  Is there any reason why this should not be removed from
the sources.  It's not used anyway :/

I'm talking about pieces of code like the following:

    #ifdef CONSOLE_TTY
    static char         *Console = CONSOLE_TTY;
    #endif

or parts like the even more exotic:

            while ((c = getopt(argc, argv, "Dc:dpt:w:")) != -1) {
                    switch (c) {
                    ...
                    case 'c':
    #ifdef CONSOLE_TTY
                            Console = optarg;
    #else
                            usage();            /* XXX */
    #endif
                            break;

The code is cluttered all over with #ifdef'ed pieces of code that are
not used.  Is it really necessary that we keep these parts?

-giorgos


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-hackers" in the body of the message

Reply via email to