On Fri, 31 Aug 2001 [EMAIL PROTECTED] wrote:
> > I see (amost).
> >
> > Please format the macro the same as the other macros in the file.
>
> Index: apic_vector.s
> ===================================================================
> RCS file: /home/ncvs/src/sys/i386/isa/apic_vector.s,v
> retrieving revision 1.47.2.4
> diff -u -r1.47.2.4 apic_vector.s
> --- apic_vector.s 18 Jul 2000 21:12:41 -0000 1.47.2.4
> +++ apic_vector.s 31 Aug 2001 19:24:24 -0000
> @@ -653,7 +707,14 @@
> FAST_INTR(21,fastintr21)
> FAST_INTR(22,fastintr22)
> FAST_INTR(23,fastintr23)
> -#define CLKINTR_PENDING movl $1,CNAME(clkintr_pending)
> +
> +#define CLKINTR_PENDING \
> + pushl $clock_lock; \
> + call s_lock; \
> + movl $1,CNAME(clkintr_pending); \
> + call s_unlock; \
> + addl $4, %esp
> +
> INTR(0,intr0, CLKINTR_PENDING)
> INTR(1,intr1,)
> INTR(2,intr2,)
>
The other macros also have a space befor the semicolons :). Otherwise OK.
Better commit this (especially to 4.4R) until we have something better.
Bruce
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-hackers" in the body of the message
