Brian Somers <[EMAIL PROTECTED]> writes:
> This looks good. I'd say you should commit the change yourself -
> feel free to say it's reviewed by me.
I'm not a src/ committer.. :-/
> As an aside, when I did this to if_tun, I chose to do all the
> destroy_dev()s at module unload time (I guess the snp device could do
> with a MODULE_DECLARE). This allows the administrator to relax the
The problem with making snp a module is that it relies on hooks in the
tty subsystem which normally aren't there. Take a look at tty.c and
search for "DEV_SNP". If we wanted to make it a module, those hooks
would have to be compiled into the base kernel. Since they call some
snp-specific functions (snpin, snpinc), those would also have to be in
the base kernel. Of course, all of that stuff can be made a kernel
option, but that kind of defeats the purpose of making it a module.
Dima Dorfman
[EMAIL PROTECTED]
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-hackers" in the body of the message
