On Tue, Feb 27, 2001 at 08:53:09PM +0100, Maxime Henrion scribbled:
| talk(1) uses the isprint() function to determine if a character is
| printable. If it's not, it outputs '^' followed by the character without
| his 8th bit. However, isprint() and friends are broken currently on
| FreeBSD (at least on -STABLE), so it will never recognize an accentued
| character as printable.
isprint() has been broken for a long long time. Clive Lin
<[EMAIL PROTECTED]> was about to fix it. I know that
we have been slacking, but please give us some time.
| The attached patch remove the isprint() test so that it's possible to
| write special characters. It also removes the now useless setlocale()
| call and headers.
Have you tried setenv LC_CTYPE=en_US.ISO-8859-1 before starting
talk(1) and typing 8-bit chars? For most cases, this will work
for 8-bit chars. (Yes, it is _*BADLY*_ broken.)
| When locale support will be complete, I'm volunteer to re-introduce
| this check if someone thinks it's really worth it.
|
| Could someone review this ?
Sorry, the fact that you remove #include <locale.h> and the
check for LC_CTYPE makes this patch somewhat hard to accept.
However, I can accept a "talk-i18n" port that will go into the
ports temporarily until we fix isprint(). Would this be acceptable
for you? We can arrange to commit it as a port with you or I as
the maintainer.
--
+------------------------------------------------------------------+
| [EMAIL PROTECTED] | [EMAIL PROTECTED] |
| http://peorth.iteration.net/~keichii | Yes, BSD is a conspiracy. |
+------------------------------------------------------------------+
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-hackers" in the body of the message
