>
> :Some thoughts:
> :
> : - If you want softupdates, you need to specify the -S flag. Should
> : softupdates be the default?
>
> That's a hard one. Considering that people who have mfs in their fstab
> probably expect as little disk I/O as possible, softupdate sshould
> probably be enabled by default.
Okay. Now the -S flag is used to disable softupdates. You can find
the updated code at the same place (for your convenience, it is:
http://www.unixfreak.org/~dima/home/mount_md.c).
Also, the only reason mount_md runs tunefs is to enable softupdates.
Perhaps it would be benificial to enable it during the newfs run?
This would save one fork/exec sequence; I don't know whether it's
worth it. I wrote a small patch to newfs to add a -g flag which will
enable softupdates; you can find the diff at
http://www.unixfreak.org/~dima/home/newfs-softdep.diff. It seems like
it might be a good convenience feature (for manual newfs use and
otherwise).
>
> : - To suppress the output of disklabel/newfs/etc., it closes fds 0-2. Is
> : this evil? Should I devise another method of doing this (something
> : like opening /dev/null and dup2'ing that fd to 0-2)?
>
> Yes, that is evil. opening and dup2()ing /dev/null to 0, 1, and 2
> is the prefered method.
Fixed.
>
> : - Should there be an option to make use of md's autounit feature? I
> : don't think it will be very hard to implement, but I don't know how
> : useful it would be.
>
> Yes, I think this should be the default.
Also fixed. It now accepts '/dev/md' or 'md' as the md-device
parameter (the first after the arguments) to mean 'use autounit'.
Regards
Dima Dorfman
[EMAIL PROTECTED]
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-hackers" in the body of the message
