On Sat, Aug 24, 2013 at 06:03:37PM -0400, Eitan Adler wrote: > On Sat, Aug 24, 2013 at 4:47 PM, Jeremie Le Hen <j...@freebsd.org> wrote: > > On Sat, Aug 24, 2013 at 10:41:56AM -0400, Eitan Adler wrote: > >> On Thu, Aug 22, 2013 at 4:49 PM, Jeremie Le Hen <j...@freebsd.org> wrote: > >> > Well, whatever, if you have any concerns, objections or comments, please > >> > speak now :). > >> > >> This LGTM but please include a comment above the warning with a date / > >> release number when this compatibility can be removed. > > > > If the old variable names are deprecated in releng/10, they can be > > removed in releng/11, can't they? > > Yes, and this should be indicated in a comment. When I see > "deprecated" or "old hack" or similar terms in code it takes some > archaeology to figure out when it was added and when it could be > removed. It would be nice to help the future reader a bit.
The purpose of my question was to know what to put in the comment ;-). Thanks for pointing this out. -- Jeremie Le Hen Scientists say the world is made up of Protons, Neutrons and Electrons. They forgot to mention Morons. _______________________________________________ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to "freebsd-hackers-unsubscr...@freebsd.org"
