On Sun, Apr 21, 2013 at 11:02:43PM +0200, Jilles Tjoelker wrote: > On Sat, Apr 20, 2013 at 12:48:39AM +0200, Jilles Tjoelker wrote: > > I'm also working on pipe2() (using linuxulator work) and dup3() (patch > > from Jukka A. Ukkonen). > > This is an implementation of pipe2. As with the accept4 patch, make > sysent needs to be run in sys/kern and sys/compat/freebsd32. > > As a bonus, new architectures might implement pipe(p) as pipe2(p, 0) > avoiding the need for assembler (but behaviour is different if the > pointer is invalid).
I do not see anything wrong with the patch. That said, I prefer the pipe(2) approach of delegating the access to the usermode memory to usermode, which avoids the need of the calls to kern_close().
pgphScrSccGS0.pgp
Description: PGP signature
