On Dec 7, 2012, at 11:50 AM, Garrett Cooper wrote: > On Fri, Dec 7, 2012 at 1:07 AM, Devin Teske <devin.te...@fisglobal.com> wrote: > > ... > >> I've made some improvements to the supplied patch. Said improvements should >> address the previous issues that were preventing this from going in. >> >> Can someone test the newly-attached patch.txt and get back to me? > > The patch seems to be missing a few checks (boot_multicons, boot > -D, etc). I really wish this stuff was properly consolidated/cleaned > up -- loader.conf's console stuff is a hodgepodge mess of > duplicated/obfuscated user knobs. > Thanks, > -Garrett
I'll look into boot_multicons. However, w/respect to "boot -D", I believe that would be after the menu, so is past the point at which we need the functionality (in drawing frames from frames.4th). Also, you replied to an earlier e-mail in the thread, do note that there's an updated patch that centralizes the logic to "boot_serial?" function which returns boolean based on multiple conditions (currently takes $console and $boot_serial into consideration -- should be trivial to add a check for boot_multicons). -- Devin _____________ The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you. _______________________________________________ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to "freebsd-hackers-unsubscr...@freebsd.org"
