On Jun 19, 2011, at 10:50, Chris Rees wrote:
> On 19 June 2011 09:15, Henrik Brix Andersen <b...@freebsd.org> wrote:
>> 
>> On Jun 17, 2011, at 18:40, Chris Rees wrote:
>>> Macros are being tested for bsd.port.mk that use a new class of files,
>>> in the same vein as the BINOWN variables I have introduced CONFOWN,
>>> CONFGRP, CONFMODE and CONFDIR.
>>> 
>>> Please would someone review and give an opinion on [1]?
>> 
>> Shouldn't $CONFDIR be set to ${PREFIX}/etc/ instead of /etc?
>> 
>> Also, if we define $CONFDIR, we should use it everywhere in bsd.*.mk where 
>> we currently use some form of */etc/* - otherwise we will get a mismatch if 
>> $CONFDIR is changed from the default.
> 
> CONFDIR is for base, not ports, just like most other stuff in that
> file. Have a look at the other DIR variables.

Gah, I was confused by you initial mail mentioning bsd.port.mk.

Rereading the patch, I think it looks good. I'd love to see this go in before 
9.0 as well.

Brix
-- 
Henrik Brix Andersen <b...@freebsd.org>





Attachment: PGP.sig
Description: This is a digitally signed message part

Reply via email to