On Jun 5, 2011, at 4:13 AM, Ben Laurie wrote: > On 05/06/2011 06:03, Warner Losh wrote: >> I'd add them for all !_LP64 architectures: arm, mips o32, mips n32, i386, >> and powerpc... > > Forgive the stupid question, but ... add them to what?
If they aren't already defined by the compilers, those compilers should be modified to define them. I thought they were defined already, it appears not. Warner >> Warner >> >> On Jun 4, 2011, at 2:41 PM, Ben Laurie wrote: >> >>> It turns out that both clang and gcc define _LP64 when used native on amd64. >>> >>> Neither defines _ILP32 on i386 (native or cross-compiled). >>> >>> dt_popc() in cddl/contrib/opensolaris/lib/libdtrace/common/dt_subr.c >>> needs on or the other. clang notices because when _ILP32 is missing >>> there's no return. >>> >>> So ... thoughts?-- >>> >>> http://www.apache-ssl.org/ben.html http://www.links.org/ >>> >>> "There is no limit to what a man can do or how far he can go if he >>> doesn't mind who gets the credit." - Robert Woodruff >>> >>> _______________________________________________ >>> freebsd-hackers@freebsd.org mailing list >>> http://lists.freebsd.org/mailman/listinfo/freebsd-hackers >>> To unsubscribe, send any mail to "freebsd-hackers-unsubscr...@freebsd.org" >>> >>> >> >> > > > -- > http://www.apache-ssl.org/ben.html http://www.links.org/ > > "There is no limit to what a man can do or how far he can go if he > doesn't mind who gets the credit." - Robert Woodruff > > _______________________________________________ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to "freebsd-hackers-unsubscr...@freebsd.org"
