On Wednesday, June 01, 2011 12:42:42 pm Dmitry Krivenok wrote:
> Hello Hackers,
> I think I found a bug in ksched_setscheduler() function.
> 
> 209                         rtp.prio = 
> p4prio_to_rtpprio(param->sched_priority);
>
> Shouldn't we use p4prio_to_tsprio instead of p4prio_to_rtpprio at the line 
> 209?
> This macro is defined but never used in kernel code:
> 
> $ grep -r 'p4prio_to_tsprio' /usr/src/sys/
> /usr/src/sys/kern/ksched.c:#define p4prio_to_tsprio(P)
> ((PRI_MAX_TIMESHARE - PRI_MIN_TIMESHARE) - (P))
> $
> 
> Is it a real bug or just my misunderstanding of something?

I think it is a real bug.  Can you come up with a test case to show it?

-- 
John Baldwin
_______________________________________________
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "freebsd-hackers-unsubscr...@freebsd.org"

Reply via email to