On 03/28/2011 15:38, Olivier Smedts wrote:
2011/3/28 Doug Barton<do...@freebsd.org>:
I'm starting a new thread since while the previous one contained a lot of
good information it was starting to get a big fragmented, and as someone
pointed out mergemaster is not a general solution so I want to focus on the
area that I'm actually responsible for. :)

Having read everything in the thread (and thanks to all who contributed,
btw) my current plan is to add some code to the end (in the section that
deals with things like running cap_mkdb if you update login.conf) to do the
following. Please let me know if this sounds reasonable, or if I'm missing
something:

1. If /var/db/zoneinfo exists, check to see if /etc/localtime is the same as
/usr/share/`cat /var/db/zoneinfo` and if not, prompt the user to run
tzsetup.
2. If /var/db/zoneinfo does not exist,

and /etc/localtime is not a symlink to a tz file ?

Good point, I forgot to include that. :)

I should point out that I also forgot to specifically enumerate the case where there is no /etc/localtime file (i.e., the time zone is UTC). In that case mergemaster should do nothing.

check to see if kern.osreldate is
after the date that the code was added, and if so, prompt the user to run
tzsetup.

So how would mergemaster behave after a fresh "make installworld
distribution" in an empty DESTDIR ?

If you've already installed stuff, I don't see how DESTDIR could be empty. Or am I missing something?

Isn't it supposed to do nothing in this case, because all should already be 
up-to-date ?

If there is no DESTDIR/etc/localtime, then yes, "do nothing" is the right answer, see above.


Thanks for the review,

Doug

--

        Nothin' ever doesn't change, but nothin' changes much.
                        -- OK Go

        Breadth of IT experience, and depth of knowledge in the DNS.
        Yours for the right price.  :)  http://SupersetSolutions.com/

_______________________________________________
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "freebsd-hackers-unsubscr...@freebsd.org"

Reply via email to