On Sun, Nov 21, 2010 at 10:18:13PM -0200, Carlos A. M. dos Santos wrote:
> On Sun, Nov 21, 2010 at 9:18 PM, Paul B Mahol <one...@gmail.com> wrote:
> > On Sun, Nov 21, 2010 at 9:17 PM, Andriy Gapon <a...@freebsd.org> wrote:
> >> on 21/11/2010 13:07 Paul B Mahol said the following:
> >>> This patch removes printf which spams console whenever thermal state
> >>> is changed in laptop. Source of problem is in buggy BIOS.
> >>>
> >>> diff --git a/sys/dev/acpica/acpi_thermal.c b/sys/dev/acpica/acpi_thermal.c
> >>> index 515a742..00866b2 100644
> >>> --- a/sys/dev/acpica/acpi_thermal.c
> >>> +++ b/sys/dev/acpica/acpi_thermal.c
> >>> @@ -697,11 +697,8 @@ acpi_tz_getparam(struct acpi_tz_softc *sc, char
> >>> *node, int *data)
> >>> static void
> >>> acpi_tz_sanity(struct acpi_tz_softc *sc, int *val, char *what)
> >>> {
> >>> - if (*val != -1 && (*val < TZ_ZEROC || *val > TZ_ZEROC + 2000)) {
> >>> - device_printf(sc->tz_dev, "%s value is absurd, ignored (%d.%dC)\n",
> >>> - what, TZ_KELVTOC(*val));
> >>> + if (*val != -1 && (*val < TZ_ZEROC || *val > TZ_ZEROC + 2000))
> >>> *val = -1;
> >>> - }
> >>> }
> >>
> >> As is - this is a perfect candidate for a "local only" patch.
> >> To be included into the tree - this, most probably, has to be controlled
> >> by a
> >> tunable/sysctl.
> >
> > So solution for useless console spamming is to add useless sysctl.
> >
> > For -1 values, sane default values should be picked up.
> > Anyway only _CRT is showing on console, and _PSV & _HOT are both -1 for tz0.
> >
> > I'm not first one mentioning this and issue is old several years.
>
> +1 (Compaq nx6320)Yes, almost every HP notebook seems to report -1 every few seconds.
pgp85SFuxNQ4v.pgp
Description: PGP signature
