On Sun, Nov 14, 2010 at 9:14 PM, Garrett Cooper <yaneg...@gmail.com> wrote: > libpam uses sys/time.h to pick up ctime, but it's actually defined > in time.h according to POSIX and the ctime manpage. > If someone could help review and commit this patch, it would be > much appreciated. This is part of a much larger change to fix > namespace pollution with time.h in sys/time.h.
Sorry... missed the gettimeofday requirement in the lib. The library fully compiles with this patch (where sys/time.h isn't removed). This is POSIX compliant. Thanks, -Garrett
Index: /usr/src/lib/libpam/modules/pam_unix/pam_unix.c =================================================================== --- /usr/src/lib/libpam/modules/pam_unix/pam_unix.c (revision 215333) +++ /usr/src/lib/libpam/modules/pam_unix/pam_unix.c (working copy) @@ -50,6 +50,7 @@ #include <string.h> #include <stdio.h> #include <syslog.h> +#include <time.h> #include <unistd.h> #include <libutil.h>
_______________________________________________ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to "freebsd-hackers-unsubscr...@freebsd.org"