:Your new "behavior" flag isn't known by vm_map_simply_entry, so
:map simplification could drop the behavior setting on the floor.
:I would prefer that the behavior is folded into eflags.
:
:Overall, I agree with the direction. Behavior is correctly a map
:attribute rather than an object attribute.
:
: Alan
:
:P.S. The MADV_FREE's by malloc/free were disabled by default in -CURRENT
:and -STABLE prior to the release of 3.2. They were a performance
:pessimization, slowing down "make world" by ~2%.
No problem, I think the behavior can easily be folded into eflags,
which deals with the map simplification code as well.
I'll work up a new patch.
-
I'm not sure I see how MADV_FREE could slow performance down unless,
perhaps, it is the overhead of the system call itself. e.g. if malloc
is calling it on a page-by-page basis and not implementing any hysteresis.
2% isn't a big deal. MADV_FREE theoretically makes a big impact on
paging performance in a heavily loaded & paging system. If your tests
were run on a system that wasn't paging, you weren't testing the right
thing.
-Matt
Matthew Dillon
<dil...@backplane.com>
To Unsubscribe: send mail to majord...@freebsd.org
with "unsubscribe freebsd-hackers" in the body of the message
