> > > @@ -302,14 +303,15 @@
> > > struct ifnet *rif, struct ifnet *oif)
> > > {
> > > if (ip) {
> > > + struct tcphdr *const tcp = (struct tcphdr *)((u_int32_t *)ip+ip->ip_hl);
> > > + struct udphdr *const udp = (struct udphdr *)((u_int32_t *)ip+ip->ip_hl);
> > > + struct icmp *const icmp = (struct icmp *)((u_int32_t *)ip+ip->ip_hl);
> > > static u_int64_t counter;
> > > - struct tcphdr *const tcp = (struct tcphdr *) ((u_int32_t *) ip+
> > > ip->ip_hl);
> > > - struct udphdr *const udp = (struct udphdr *) ((u_int32_t *) ip+
> > > ip->ip_hl);
> > > - struct icmp *const icmp = (struct icmp *) ((u_int32_t *) ip +
> > > ip->ip_hl);
> > > - int count;
> > > + u_int64_t count;
> >
> > These are mostly change for changes sake, and make it difficult to see
> > the functional changes. Please limit your changes to changes, and not
> > just to add stylistic differences. While I may agree with them, they
> > detract from the review process.
>
> These were changes that were necessary to make ipfw readable enough that
> I could work with it in this area. They aren't just to clean it up, or
> just for change's sake. They need to stay in.
C'mon now, re-ording the lines is *certainly* not necessary to work.
*rant on*
Brian, FreeBSD isn't your private playground for playing around, this is
a group project, and you gotta follow the rules, or you don't get to
play with the rest of the folks....
*rant off*
Nate
To Unsubscribe: send mail to majord...@freebsd.org
with "unsubscribe freebsd-hackers" in the body of the message
