:> between NFSv2 and NFSv3. :Yes, I concur with your patch whole-heartedly. Apparently last night I :was too-tired, and not intoxicated enough to understand the nfs_serv.c code :) : :I alas will not be able to test it. The machine is up and stable with 3k :mbufs in reserve.. maybe later :) : :As an aside, what about getting rid of that mbuf leak if a nfs-service :routine returns with error!=0? : :-- :David Cross | email: cro...@cs.rpi.edu
Well, theoretically we just free the mbuf in the error case within nfs_syscalls.c/nfssvc_nfsd(), around line 661 (STABLE), or 650 (CURRENT). Realistically every single nfs server procedure would need to be audited to make sure that a non-NULL *mreq is valid in all error cases - not something I particularly want to do without commit privs from a crediting point of view. -Matt Matthew Dillon <dil...@backplane.com> To Unsubscribe: send mail to majord...@freebsd.org with "unsubscribe freebsd-hackers" in the body of the message