VOP_LEASE(...) always returns 0 so there is no actual need to check its
return value. But still it has a return value.  So should we use
(void)VOP_LEASE(...) instead of just VOP_LEASE(...)? 

BTW, I guess that the practice of modifying
default_vnodeop_p[VOFFSET(vop_lease)] in nfs_init() is a hack. Why do not
we use

   { &vop_lease_desc,              (vop_t *) nqnfs_vop_lease_check }, 

instead of 

   { &vop_lease_desc,              (vop_t *) vop_null },

in nfsv2_vnodeop_entries[] in file nfs_vnops.c?

Thanks for any help.

--------------------------------------------------
Zhihui Zhang.  Please visit http://www.freebsd.org
--------------------------------------------------



To Unsubscribe: send mail to [email protected]
with "unsubscribe freebsd-hackers" in the body of the message

Reply via email to