On 25-Jun-00 Motomichi Matsuzaki wrote:
> 
> Hi.
> 
> ** this discussion is for i386 architectures **
> 
> I think there is some unclearness on the description 
> about VM subsystem coloring in NOTES (formerly called LINT).
> 
> Currently,
> 
># Options for the VM subsystem
>#options        PQ_NOOPT                # No coloring
> options         PQ_LARGECACHE           # color for 512k/16k cache
>#options        PQ_HUGECACHE            # color for 1024k/16k cache
>#options        PQ_MEDIUMCACHE          # color for 64k/16k cache
>#options        PQ_NORMALCACHE          # color for 256k/16k cache
> 
> 
> But, in /sys/vm/vm_page.h, PQ_PRIME1, PQ_PRIME2, PQ_L2_SIZE are
> defined as below.
> 
> PQ_NOOPT      defines 1/1/1           to disable coloring
> PQ_LARGECACHE defines 31/23/128       for 512k cache
> PQ_HUGECACHE  defines 31/23/256       for 1M cache
> PQ_MEDIUMCACHE        defines 13/7/64         for 256k cache
> PQ_NORMALCACHE        defines 5/3/16          for 64k cache
> 
> and, on the default, these parameters are defined as 9/5/32.
> 
> NOTES has obviously incorrect description about MEDIUM and NORMAL
> case, and there are no discription about the default coloring.
> 
> Yes, this situation arise from its incomprehensive name.
> I suggest that these options should be renamed as follows:
> 
> currently     ->      candidate
> PQ_HUGECACHE          PQ_CACHE1024
> PQ_LARGECACHE         PQ_CACHE512
> PQ_MEDIUMCACHE                PQ_CACHE256
> PQ_NORMALCACHE                PQ_CACHE64
> 
> and newly PQ_CACHE128 should be defined as default.
> 
> Any ideas?

Sounds ok to me.  Do you have any patches for this?  If not,
I'll make some and see if they pass muster.

-- 

John Baldwin <[EMAIL PROTECTED]> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.cslab.vt.edu/~jobaldwi/pgpkey.asc
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-hackers" in the body of the message

Reply via email to