Re: Portable way to compare struct stat's?

[Peter Wemm]

Kelly Yancey wrote:
[..]
>   For the list: while I was checking OpenBSD's kern_descrip.c to see
> whether they zeroed the memory first, I noticed that they had the
> following check that my 3.3-stable system does not:
> 
>       [ ... ]
>       /* Don't let non-root see generation numbers (for NFS security) */
>       if (suser(p->p_ucred, &p->p_acflag)) ub.st_gen = 0;
>       [ perform copyout ... ]
> 
>   Is this a legitimate concern or paranoia? I see that we don't bother in
> -current with it either.

We do this too, but elsewhere...
int
vn_stat(vp, sb, p)
{
        ...
                if (suser_xxx(p->p_ucred, 0, 0))
                sb->st_gen = 0;
        else
                sb->st_gen = vap->va_gen;
        ...
}

Cheers,
-Peter
--
Peter Wemm - [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]



To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-hackers" in the body of the message