On 28/01/2017 15:23, Poul-Henning Kamp wrote: > -------- > In message <8de79017-f0b0-c86a-93c5-65be4d97b...@freebsd.org>, Andriy Gapon > wri > tes: > >> So, the correct sequence should be: >> - call disk_gone() to prevent new I/O >> - handle all in-flight I/O >> - call disk_destroy() >> Is that right? > > exactly!
Thank you! And, just in case, I am seeing this problem with mfi driver. It uses disk(9) API directly to represent disks behind the controller. It seems that we have a class of such drivers and probably all of them are affected. Here is a list of files where I see disk_destroy, but no disk_gone: /usr/src/sys/dev/mlx/mlx_disk.c /usr/src/sys/dev/aac/aac_disk.c /usr/src/sys/dev/twe/twe_freebsd.c /usr/src/sys/dev/ips/ips_disk.c /usr/src/sys/dev/ida/ida_disk.c /usr/src/sys/dev/mfi/mfi_syspd.c /usr/src/sys/dev/mfi/mfi_disk.c /usr/src/sys/dev/cfi/cfi_disk.c /usr/src/sys/dev/amr/amr_disk.c The list is not complete. -- Andriy Gapon _______________________________________________ freebsd-geom@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-geom To unsubscribe, send any mail to "freebsd-geom-unsubscr...@freebsd.org"
