-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/17/2012 06:30 AM, Pawel Jakub Dawidek wrote: > On Fri, Jun 15, 2012 at 06:16:51PM -0400, John W. O'Brien wrote: >> @@ -58,7 +58,7 @@ .Op Fl i Ar iterations .Op Fl J Ar newpassfile >> .Op Fl K Ar newkeyfile -.Op Fl l Ar keylen +.Op Fl l Ar >> datakeylen > > I wouldn't change that. It is called 'keylen' also in geli(8) > usage. > >> @@ -83,7 +83,7 @@ .Op Fl d .Op Fl a Ar aalgo .Op Fl e Ar ealgo >> -.Op Fl l Ar keylen +.Op Fl l Ar datakeylen > > Same here. > >> -.It Fl l Ar keylen -Key length to use with the given >> cryptographic algorithm. +.It Fl l Ar datakeylen > > And here.
The /keylen/datakeylen/ change shows up in four places, including the usage section. % grep -n keylen geli.8 61:.Op Fl l Ar datakeylen 86:.Op Fl l Ar datakeylen 322:.It Fl l Ar datakeylen 445:.It Fl l Ar datakeylen I thought about changing the 'keyfile' parameter name too, but that applies in loader.conf, so I left it alone. In any case, I don't feel that strongly about it. I'll back out those four lines and post an updated patch to the PR. John -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJP3yIYAAoJEEdKvTwaez9wNJYH/3rowPCQIxqiVrd4f0OmYsn7 Us9Sx/udaknznfhW824r040EsXZDD0uC/Ka22XKMLXwAeTMIrQPGdUox6sxMuQuF 6S/g0I3rti+ECwEmERnIYtbspHWO1HktvrpStdtwVag98H9uFtd9dKhPYMJIK96t jFKx5VDUyP5KL+4WbM/0avRJqilGs5Xk4nnZ2Ad68H6XZzWPd7VRMtaMaQrQ6Bmt 43xG4nalbQ7bCzWSE0rhcU+znAVxKtlG8cbH7H/lvcgbrUUK10L0sBDHZ4qjbciC V8dvg3rfQvUzZsA9gzWwBtbxRSyB4XhRmryckc8cYhldDDE1P9pB1PewfyVxv/s= =Spam -----END PGP SIGNATURE----- _______________________________________________ freebsd-geom@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-geom To unsubscribe, send any mail to "freebsd-geom-unsubscr...@freebsd.org"
