Morten Rodal wrote:
> On Tue, Feb 25, 2003 at 07:28:09PM +0100, Maxime Henrion wrote:
> [snip a lot of the patch]
> > @@ -1431,7 +1442,8 @@
> > SLIST_FOREACH(at, &sc->alloc_list, list) {
> > if (offset >= at->address &&
> > offset < at->address + at->size)
> > - return atop(vtophys(offset));
> > + *paddr = vtophys(offset);
> > + return 0;
> > }
> >
> > return -1;
>
> Should the function return 0 even if the if (offset..) fails? I have
> no clue about the nvidia kernel driver (or kernel stuff at all) but it
> seems to me that the only way the function can return -1 is if the
> list is empty.
And this is consistant with what the code was doing before. This change
is not a functional change, it's just a necessary update due to API
changes.
Cheers,
Maxime
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
