On Mon, 10 Feb 2003 13:31:48 +1100
Tim Robbins <[EMAIL PROTECTED]> wrote:

> 
> hashinit() can sleep, and I don't think it's safe to sleep here
> (msdosfs_hashget() and msdosfs_hashins()) with dehash_mtx and
> sometimes a vnode lock held.

Doh! I should have noticed that.

> 
> It might be better to initialise the table the first time an
> msdosfs filesystem is mounted.
> 

Sounds reasonable enough. So, maybe allocate it in msdosfs_mount or mountmsdosfs
and deallocate it in msdosfs_unmount? If there isn't an easy way to tell if
you're on the last mounted msdos filesystem, it might be better to just
leave the deallocation in msdosfs_uninit. Is that basically what you're saying?

Cheers.
-- 
Mike Makonnen  | GPG-KEY: http://www.identd.net/~mtm/mtm.asc
[EMAIL PROTECTED] | Fingerprint: D228 1A6F C64E 120A A1C9  A3AA DAE1 E2AF DBCC 68B9

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to