Marcel Moolenaar wrote: > On Sun, Jan 12, 2003 at 06:27:00PM -0800, Terry Lambert wrote: > > Therefore, it seems to me, that the correct place to put them is in > > the <machine/floatingpoint.h> header (the other alternative was the > > <machine/ieeefp.h> header; this seemed wrong to me, but I'm willing > > to reroll the patch, if there's a lot of disagreement over this point). > > I would like to see it in <machine/ieeefp.h>:
I didn't put it there because that's not where the i386 is getting its version of fpsetmask(), et al. As I said, I'd be happy to reroll the patch, and be overruled. Should I move the i386 inline function and #define's from the machine/floatingpoint.h to the machine/ieeefp.h, as well? It seems to me that all the symbols should come from that place, on all architectures, no matter what place it ends up being. > The synopsis section of our manpage clearly states the inclusion > of <ieeefp.h>. That header file includes a machine dependent > counterpart <machine/ieeefp.h>. On alpha, ia64 and sparc64 > <machine/floatingpoint.h> is empty with the exception of the > inclusion of <machine/ieeefp.h>. Actually, on SPARC and i386, it puts _FLOATINGPOINT_H_ into scope, too, while on IA64 and Alpha, it doesn't (which is broken, for the #include #ifndef/#define ... /#endif style). > Hence, I would like to see the prototypes and/or implementation > in <machine/ieeefp.h>. Since on i386 <machine/floatingpoint.h> > also includes <machine/ieeefp.h>, we should be able to move > the implementation on i386 to <machine/ieeefp.h> as well. If > possible, I'd like to see <machine/floatingpoint.h> retired > unless there's a compelling reason to keep it... Well, that answers my question from above: "yes". 8-). -- Terry To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
