In message <[EMAIL PROTECTED]>, Bruce Evans writes:
>The following change uncovers bugs in specfs locking and other places: Wow, that was fun! :-/ I always wondered why specfs would insist on no locking, but I never had much ambition for finding out. >Fixing specfs is simple: This is not tested with DEVFS I take it ? > >Bugs found while investigating this: >- spec_print() is unreachable because ufs_vnops.c overrides it. >- spec_print() is of low quality: it doesn't print the device name or number. spec_print should probably just be retired, after all specfs is only a set of common helper functions and not a filesystem as such. >- the vop tables work even worse than might first appear. I agree, but I have no ambition to fiddle with the mechanics of them. >- other entries in specfs's vop table seem to be unreachable or unnecessary > (because the default is better). Suggestions ? >- deadfs is also missing an override for vop_islocked. This is OK provided > it is never passed locked vnodes. I have no opinion on this one. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 [EMAIL PROTECTED] | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
