In message <[EMAIL PROTECTED]>, Trent Nelson writes:
>
> I've written an extension to systat that allows you to monitor the
> traffic through active network interfaces on the system, akin to
> netstat -I. I've attached the patch to this e-mail, but it can also be
> found at http://arpa.com/~trent/systat-ifstat-current.patch[.tar.gz].
>
> All comments on code, style or functionality are welcome.
This looks pretty useful.
As far as I can see you have some genuine fixes in there:
>diff -uBN /shared/data/trent/src/src/usr.bin/systat/cmds.c
>/usr/src/usr.bin/systat/cmds.c
>--- /shared/data/trent/src/src/usr.bin/systat/cmds.c Wed Dec 12 00:13:37 2001
>+++ /usr/src/usr.bin/systat/cmds.c Sat Jan 4 14:11:32 2003
>@@ -119,6 +119,7 @@
> goto done;
> alarm(0);
> (*curcmd->c_close)(wnd);
>+ curcmd->c_flags &= ~CF_INIT;
> wnd = (*p->c_open)();
> if (wnd == 0) {
> error("Couldn't open new display");
We should probably commit them in a separate commit first.
>diff -uBN /shared/data/trent/src/src/usr.bin/systat/convtbl.c
>/usr/src/usr.bin/systat/convtbl.c
>--- /shared/data/trent/src/src/usr.bin/systat/convtbl.c Thu Jan 1 01:00:00
>1970
>+++ /usr/src/usr.bin/systat/convtbl.c Sat Jan 4 00:13:11 2003
>@@ -0,0 +1,98 @@
This is only used for the ifstat page, right ? Should/Could bits
of the other code use it as well ?
>diff -uBN /shared/data/trent/src/src/usr.bin/systat/systat.1
>/usr/src/usr.bin/systat/systat.1
>--- /shared/data/trent/src/src/usr.bin/systat/systat.1 Fri Dec 27 12:15:35 2002
>+++ /usr/src/usr.bin/systat/systat.1 Sat Jan 4 14:31:06 2003
>@@ -30,7 +30,7 @@
> .\" SUCH DAMAGE.
> .\"
> .\" @(#)systat.1 8.2 (Berkeley) 12/30/93
>-.\" $FreeBSD: src/usr.bin/systat/systat.1,v 1.36 2002/12/27 12:15:35 schweikh Exp $
>+.\" $FreeBSD: src/usr.bin/systat/systat.1,v 1.23.2.9 2002/12/29 16:35:40 schweikh
>Exp $
This looks worrisome to me, and some of the deltas look more so:
>@@ -500,8 +522,8 @@
> .Xr iostat 8 ,
> .Xr vmstat 8
> .Sh FILES
>-.Bl -tag -width /boot/kernel/kernel -compact
>-.It Pa /boot/kernel/kernel
>+.Bl -tag -width /etc/networks -compact
>+.It Pa /kernel
> For the namelist.
> .It Pa /dev/kmem
> For information in main memory.
Otherwise I think it looks good.
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
[EMAIL PROTECTED] | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
