It seems Bruce Evans wrote:
> Single-digit track numbers are correct and are still generated by MAKEDEV.

Single digit track numbers are wrong and should be fixed in MAKEDEV.

> The devfs numbers were broken in:
> 
> % RCS file: /home/ncvs/src/sys/dev/ata/atapi-cd.c,v
> % Working file: atapi-cd.c
> % head: 1.126
> % ...
> % ----------------------------
> % revision 1.119
> % date: 2002/05/28 17:39:17;  author: sos;  state: Exp;  lines: +1 -1
> % Use %02d in track numbers, so that 1 is 01, much easier for scripts
> % ----------------------------
> 
> Contrary to the log message, %02d is harder for scripts.  It gives many
> more cases to handle:
> - %d format under RELENG_4

Should be fixed.

> - %d format under -current in the non-devfs case

DEVFS should be considered mandatory for the track devices on current.

> - %d format under -current even in the devfs case for track numbers >= 100

BZZT!! there can be a max of 99 tracks on a CD.

> - %02d under -current in the devfs case for track numbers < 100.

Thats actually the one thats right :)

> The following patch backs out rev.1.119 of atapi-cd.c and fixes the
> following older devfs bugs in acd:
> - insecure permissions.  Among other holes, these allowed the world to
>   erase cd-rw's.

Use rc.devfs for that as it was intended.

> - hard-coded ownerships leading to broken groups for the track devices.

Well, that sounds like a bug alright...

-Søren

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to