On Fri, 8 Nov 2002, Pierre Beyssac wrote:
> Fine, but if included "as is" in Wine because, it will break
> compatibility with Net/OpenBSD because DBREG_DRX is a FreeBSDism...
> that's why I surrounded my patch with a #ifdef DBREG_DRX (which
> seems cleaner than a #ifdef __FreeBSD__).

Sheesh.

PHK, now we have the situation where user programs require #ifdefs
to be portable among the BSDs when this was not required before.

Please consider reverting

  revision 1.28
  date: 2002/10/20 20:48:56;  author: phk;  state: Exp;  lines: +6 -9
  Change the definition of the debugging registers to be an array, so
  that we can index into it, rather than do pointer gymnastics on a
  structure containing 8 elements.

in src/sys/i386/include/reg.h.

Gerald

PS: Pierre, thanks a lot for spotting and addressing this! I certainly
agree with preferring #ifdef DBREG_DRX over #ifdef __FreeBSD__.


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to