On Sat, Aug 10, 2002 at 02:02:39PM +0200, Eirik Nygaard wrote:
> I have just rewritten the rmuser perl script to C, it would be 
> great if you could take a look at it and check if everything is ok.

You should probably replace the strcpy() and strcat() with strlcpy(3) and
strlcat(3), or at least use the strncpy(3) and strncat(3). Also, sprintf()
should be replaced with snprintf(3).

Maybe close the file descriptors in the signal handlers?

> 
> How do I get this commited?

Now that I cannot answer for :)

--

Morten Rodal

//
// PGP ID 2D75595B
// 22DE D67A 1AEA EF94 872A  9384 6D67 B50B 2D75 595B
//


Attachment: msg41750/pgp00000.pgp
Description: PGP signature

Reply via email to