On Fri, 2002-06-21 at 15:59, Alexander Kabaev wrote:
> Why not to use GCC version itself to distinguish between
> thunked/non-thunked vtable implementations? 

The full comments in the header file illustrate why the Mozilla teamed
keyed off of the internal compiler revision.  Basically, almost all
ports-based compilers were thunked, and there was a short period of time
in early 4.0 when a thunked system GCC was in the tree.

Note, we are using the FreeBSD compiler revision, and not
__FreeBSD_version in this header.

Joe

> 
> > > Please add a comment why you chose these __FreeBSD_cc_version
> > > values. What is special about 500003?  500003 is 5.0-CURRENT after
> > > buf/bio changes, *years* ago.  Perhaps you wanted another value from
> > > 
>http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/freebsd-versions.html
> > 
> > Fear not.  I'm modifying the patch.  Proper documentation will be
> > included.
> > 
> > Joe
> -- 
> Alexander Kabaev
> 

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to