Hi all,
I just fixed a bug that has been hitting me everytime I do a sysctl -a since inp locking was committed. I would like to commit it as soon as possible, so I'd like it if someone could review it. Thanks, Maxime
Index: udp_usrreq.c =================================================================== RCS file: /space2/ncvs/src/sys/netinet/udp_usrreq.c,v retrieving revision 1.113 diff -u -p -r1.113 udp_usrreq.c --- udp_usrreq.c 14 Jun 2002 08:35:14 -0000 1.113 +++ udp_usrreq.c 21 Jun 2002 13:31:27 -0000 @@ -617,8 +617,10 @@ udp_pcblist(SYSCTL_HANDLER_ARGS) INP_LOCK(inp); if (inp->inp_gencnt <= gencnt) { if (cr_canseesocket(req->td->td_ucred, - inp->inp_socket)) + inp->inp_socket)) { + INP_UNLOCK(inp); continue; + } inp_list[i++] = inp; } INP_UNLOCK(inp);