On Fri, Jun 22, 2001 at 10:35:32AM -0700, John Baldwin wrote:
> 
> On 22-Jun-01 Alfred Perlstein wrote:
> > * Alexander N. Kabaev <[EMAIL PROTECTED]> [010622 10:46] wrote:
> >> UP kernel can not be compiled in -CURRENT after your changes because
> >> kern/subr_mbuf.c references mp_ncpus variable, which is defined only in SMP
> >> case. Should this variable be moved out of #ifdef SMP?
> > 
> > Yes, I asked for this months ago, I thought it was already done.
> 
> mp_npcus is not initialized, etc. in the UP case.  I suppose it could be
> statically initialized to 1 and moved, but in that case it needs renaming, as
> mp_ncpus implies SMP (mp_ prefix).  If you want to make it ncpus and move it to
> sys/systm.h and stick it somewhere MI initialized to 1 that is fine.  Then
> hw.ncpus can reference that (well, it's called hw.ncpu right now, perhaps it
> should be renamed to match the variable *shrug*) and kern.smp.cpus can die as
> it won't be needed any longer.

        Note that we already have a (machdep, I think) sysctl exported ncpu
variable.
 
> > -Alfred
> 
> -- 
> 
> John Baldwin <[EMAIL PROTECTED]> -- http://www.FreeBSD.org/~jhb/
> PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
> "Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/
> 

-- 
 Bosko Milekic
 [EMAIL PROTECTED]


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to