In article <local.mail.freebsd-current/[EMAIL PROTECTED]> you write:
>On Sat, Jan 27, 2001 at 12:36:41PM -0800, Matthew Jacob wrote:
>>
>> Oh, I suppose, I did find that... well, mainly I wanted the person who made
>> the change to actually broadcast to NIC maintainers what the expectations
>> were...
>
>The code that prints these warnings out has existed for a while. However,
>whoever added it made a bad assumption about the internals of the mutex
>implementation, so the code never got executed. I "fixed" it last week, so
>the warnings get printed now.
Actually, I think it was correct at the time I added it. Anything
that calls if_attach (or ether_ifattach) will automatically have the
mutex correctly initialized, so the driver doesn't have to do anything
extra.
e.g.:
ifp->if_name = "lo";
ifp->if_unit = i++;
ifp->if_snd.ifq_maxlen = ifqmaxlen;
if_attach(ifp);
if_attach(ifp)
{
....
mtx_init(&ifp->if_snd.ifq_mtx, ifp->if_name, MTX_DEF);
...
}
I'm not up-to-date with -current at the moment, so I'm not sure
why things aren't working any more.
--
Jonathan
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
