Re: pw_class in _pw_passwd is null if __hashpw() is not called in prior

[Jacques A. Vidrine]

On Sun, Sep 24, 2000 at 11:43:01PM +0900, Seigo Tanimura wrote:
> As we are supposed to fill in all of the members in struct passwd
> (like Solaris), _pw_passwd should have its initial value other than
> zero.
> 
> static struct passwd _pw_passwd =
> {
>       "",
>       "",
>       (uid_t)0,       /* XXX Is zero appropriate? */
>       (gid_t)0,
>       (time_t)0,
>       "",
>       "",
>       "",
>       "",
>       (time_t)0,
>       0,
> };

I agree -- it bit me while working on some additional nsswitch
backends.  Using a pointer to an empty string would be more safe.  As
to the XXX comment, those fields have been 0 forever, no point in
changing them now.  Unless objections come up, I'll commit this change
or something similar with the next nsswitch commit.

Thanks for the suggestion!
-- 
Jacques Vidrine / [EMAIL PROTECTED] / [EMAIL PROTECTED] / [EMAIL PROTECTED]


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message