On Wed, Aug 16, 2000, Poul-Henning Kamp wrote:
> 
> Please test and review this patch:
> 
> http://phk.freebsd.dk/patch/vop_stdaccess.patch
> 
> This patch creates a centralized function "vop_stdaccess()" which
> does the "canonical" permission check on a vnode.
> 
> This code was duplicated in 5 filesystems and morphed in a 6th.
> 
> Files touched:
> 
>       Index: fs/hpfs/hpfs_vnops.c
>       Index: isofs/cd9660/cd9660_vnops.c
>       Index: kern/vfs_default.c
>       Index: miscfs/kernfs/kernfs_vnops.c
>       Index: msdosfs/msdosfs_vnops.c
>       Index: ntfs/ntfs_vnops.c
>       Index: sys/vnode.h
>       Index: ufs/ufs/ufs_vnops.c
> 
> Linecount: removes: 243 adds: 79 net change: -164

I reviewed this last night and it looks good. Perhaps someone with
credential clue could suggest a change to the cred_uid == 0 check .. ?



Adrian

-- 
Adrian Chadd                    Now 17-year-olds can't play a _video game_
<[EMAIL PROTECTED]>            because its called violent -
                                and real violence is still called dinner.
                                        -- [EMAIL PROTECTED]


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to