On Apr 13, 2023, at 21:27, Charlie Li <vish...@freebsd.org> wrote: > > Pawel Jakub Dawidek wrote: >> On 4/14/23 09:23, Charlie Li wrote: >>> Pawel Jakub Dawidek wrote: >>>> Here is the change that reverts most of the modifications and disables >>>> cloning new blocks. It does retain ability to free existing cloned blocks >>>> and keeps block_cloning feature around, so upgraded pools can be imported >>>> and existing cloned blocks freed. >>>> >>>> It does not handle replaying ZIL with block-cloning logs, so make sure you >>>> import pools that were cleanly exported. >>>> >>>> I'd appreciate if someone who can reproduce those corruptions could try it. >>>> >>>> https://github.com/pjd/openzfs/commit/f2cfbcf76a733c44e25cba8c649162ef68047103 >>>> >>> Does not apply to sys/contrib/openzfs tip, conflicts in >>> module/os/freebsd/zfs/zfs_vnops_os.c and module/zfs/dmu.c. >> This should work: >> https://people.freebsd.org/~pjd/patches/brt_revert.patch > This results in missing files rather than corruption.
FYI: in my original report for a context that has never had block_cloning enabled, I reported BOTH missing files and file content corruption in the poudriere-devel bulk build testing. This predates: https://people.freebsd.org/~pjd/patches/brt_revert.patch but had the changes from: https://github.com/openzfs/zfs/pull/14739/files The files were missing from packages installed to be used during a port's build. No other types of examples of missing files happened. (But only 11 ports failed.) === Mark Millard marklmi at yahoo.com
