RES: RES: RES: vt newcons mouse paste issue FIXED

[Ivan Quitschal]

Hi 

This change unfortunately didnt compile on my 13-stable . I just git cloned the 
CURRENT code, applied the patch and the build was fine.
I'll test it as soon as I finish the upgrade from stable to current here

I'll get back here when its finished 


Thank you 


-----Mensagem original-----
De: Hans Petter Selasky <h...@selasky.org> 
Enviada em: quarta-feira, 22 de junho de 2022 14:08
Para: Tomoaki AOKI <junch...@dec.sakura.ne.jp>; Ivan Quitschal 
<tez...@hotmail.com>
Cc: freebsd-current@freebsd.org; Kurt Jaeger <p...@freebsd.org>
Assunto: Re: RES: RES: vt newcons mouse paste issue FIXED

On 6/22/22 18:48, Tomoaki AOKI wrote:
> Hi.
> 
> Not actually tested, but this can cause breakage on non-ascii cases.
> Maybe also (or instead) iswspace() test would be needed.
> Possibly additional mbrtowc() in the argument of iswspace().
> 
> Please see `man 3 multibyte` and `man 3 iswspace`.
> (Possibly more to see.)
> 
> Characters in buf can be multibyte or wide char depending on locale, 
> as vt can show at least UTF-8 characters.
> 
> Sorry, not looked into enough how UTF-8 characters outside ascii are 
> handled internally on vt.
> 

Thanks for your feedback.

Now using the TCHAR_CHARACTER() macro, which is already used for space 
separation.

See:
https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.freebsd.org%2FD35552&amp;data=05%7C01%7C%7C179337d1a7a340b8a9eb08da5471c67e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637915144907733421%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=b4hKmkmuXxZ%2BjtSv75bG8qLIXMwo9Fzt64NfVSnuDUU%3D&amp;reserved=0

--HPS