On 01/07/14 03:30, Huang Wen Hui wrote:
Hans,

This wild guess do NOT works.
I binary sect xhci.c in SVN, found that *r245732
*<http://svnweb.freebsd.org/base?view=revision&revision=245732>*
introduce the bug.*
  <http://svnweb.freebsd.org/base?view=revision&revision=245732>
revert to r345731 fixed this USB problem in 9.2R

I also copy xhci_interrupt(struct xhci_softc *sc) from 9.1R to CURRENT,
CURRENT also works!

Cheers,
Huang Wen Hui.


Hi,

We need to take this step by step. Thanks for tracing this down!

Can you test the attached patch towards -current.

Thank you!

--HPS


=== ./xhci.c
==================================================================
--- ./xhci.c	(revision 260319)
+++ ./xhci.c	(local)
@@ -1582,8 +1582,6 @@
 	USB_BUS_LOCK(&sc->sc_bus);
 
 	status = XREAD4(sc, oper, XHCI_USBSTS);
-	if (status == 0)
-		goto done;
 
 	/* acknowledge interrupts */
 
@@ -1591,10 +1589,8 @@
 
 	DPRINTFN(16, "real interrupt (status=0x%08x)\n", status);
  
-	if (status & XHCI_STS_EINT) {
-		/* check for event(s) */
-		xhci_interrupt_poll(sc);
-	}
+	/* check for event(s) */
+	xhci_interrupt_poll(sc);
 
 	if (status & (XHCI_STS_PCD | XHCI_STS_HCH |
 	    XHCI_STS_HSE | XHCI_STS_HCE)) {
@@ -1618,7 +1614,6 @@
 			   __FUNCTION__);
 		}
 	}
-done:
 	USB_BUS_UNLOCK(&sc->sc_bus);
 }
 
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Reply via email to