On Thu, Aug 29, 2013 at 6:03 PM, John Baldwin <j...@freebsd.org> wrote: > On Monday, August 26, 2013 3:05:06 pm John Baldwin wrote: >> On Monday, August 26, 2013 2:23:44 pm Davide Italiano wrote: >> > Please consider the following patch: >> > http://people.freebsd.org/~davide/review/socket_timeout.diff >> > I've tested it and it works OK. I got a timeout which is ~= 25ms using >> > the testcase provided by the user. >> > The only doubt I have is about the range check, I've changed a bit >> > because the 'integer' part of sbintime_t fits in 32-bits, but I'm not >> > sure it's the best way of doing this. >> >> Nice! Bruce actually wants me to adjust the range check a bit (which will >> fit in well with your changes I think). Please let me get that fix in >> (so it can be part of the future MFC) and then you can commit this. Thanks! >> >> Actually, I think you still need to patch the sogetopt() case to work >> correctly >> (it is still doing a manual conversion from 'val' to a timeval assuming it is >> in 'hz' units). > > I'm done with my range check changes, please move forward with your change > (though make sure you fix the sogetsockopt() case please). > > -- > John Baldwin
For the archives, this should be fixed in r255138. Thanks to both, -- Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare _______________________________________________ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
