On Wed, Mar 13, 2013 at 10:59:17PM +0100, Dirk Engling wrote: > > On Wed, 13 Mar 2013, Pawel Jakub Dawidek wrote: > > > How about this patch? > > > > http://people.freebsd.org/~pjd/patches/pidfile.c.patch > > If you move the lines > > + if (errno == 0 || errno == EAGAIN) > + errno = EEXIST; > > out of the else branch, you can get rid of the if branch, guard the else > branch by a > > + if (pidptr) { > > and let the if (errno == 0 || errno == EAGAIN) fix the errno
I think I considered something similar at first, but the change I proposed was optimal, IMHO at the cost of producing pretty large diff, because of indentation change. But to be sure, can you send a patch of your proposed change? -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl
pgp1futIji1g8.pgp
Description: PGP signature
