On 2012-Jul-12 10:40:27 -0400, John Baldwin <j...@freebsd.org> wrote: >contigmalloc(). In fact, even better is to call kmem_alloc_contig() directly >rather than using contigmalloc(). ... >Peter, this is somewhat orthognal (but related) to your bus_dma patch which is >what prompted me to post this.
Overall, the change seems good to me. My sole thought on the API was whether the actual attribute should be passed, rather than having a couple of new BUS_DMA_ flags but you've addressed that in a followup. One change is that previously allocated memory was all charged to M_DEVBUF via the malloc_type_allocated() call in contigmalloc() whereas now only small allocations are counted. This would seem to indicate that large bus_dmamem_alloc() allocations won't be visible in (eg) "vmstat -m". -- Peter Jeremy
pgpZoejmmJeAW.pgp
Description: PGP signature
