On Mon, May 2, 2011 at 12:48 AM, FreeBSD Tinderbox
<tinder...@freebsd.org> wrote:
[...]
> cc -c -O -pipe -std=c99 -g -Wall -Wredundant-decls -Wnested-externs
> -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline
> -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc -I.
> -I/src/sys -I/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS
> -include opt_global.h -fno-common -finline-limit=8000 --param
> inline-unit-growth=100 --param large-function-growth=1000
> -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow
> -mno-sse -mno-sse2 -mno-sse3 -msoft-float -ffreestanding -fstack-protector
> -Werror /src/sys/dev/lge/if_lge.c
> cc -c -O -pipe -std=c99 -g -Wall -Wredundant-decls -Wnested-externs
> -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline
> -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc -I.
> -I/src/sys -I/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS
> -include opt_global.h -fno-common -finline-limit=8000 --param
> inline-unit-growth=100 --param large-function-growth=1000
> -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow
> -mno-sse -mno-sse2 -mno-sse3 -msoft-float -ffreestanding -fstack-protector
> -Werror /src/sys/dev/malo/if_malo.c
> cc -c -O -pipe -std=c99 -g -Wall -Wredundant-decls -Wnested-externs
> -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline
> -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc -I.
> -I/src/sys -I/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS
> -include opt_global.h -fno-common -finline-limit=8000 --param
> inline-unit-growth=100 --param large-function-growth=1000
> -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow
> -mno-sse -mno-sse2 -mno-sse3 -msoft-float -ffreestanding -fstack-protector
> -Werror /src/sys/dev/malo/if_malohal.c
> cc -c -O -pipe -std=c99 -g -Wall -Wredundant-decls -Wnested-externs
> -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline
> -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc -I.
> -I/src/sys -I/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS
> -include opt_global.h -fno-common -finline-limit=8000 --param
> inline-unit-growth=100 --param large-function-growth=1000
> -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow
> -mno-sse -mno-sse2 -mno-sse3 -msoft-float -ffreestanding -fstack-protector
> -Werror /src/sys/dev/malo/if_malo_pci.c
> cc1: warnings being treated as errors
> /src/sys/dev/malo/if_malo_pci.c: In function 'malo_pci_attach':
> /src/sys/dev/malo/if_malo_pci.c:232: warning: large integer implicitly
> truncated to unsigned type
> /src/sys/dev/malo/if_malo_pci.c:232: warning: large integer implicitly
> truncated to unsigned type
> *** Error code 1
>
> Stop in /obj/i386.i386/src/sys/PAE.
> *** Error code 1
>
> Stop in /src.
> *** Error code 1
>
> Stop in /src.
Tinderbox has been whining about malo for the last day or so on
i386 because of this issue. Could someone please commit the following
patch to fix it? It's correct according to the printf(3) manpage
combined with the fields in the malo_hal structure.
FWIW I'm a bit confused too because it's listed in the
WITHOUT_MODULES group for several i386 kernel compiles based on my
looking at the make universe output, but it's still barfing on the
module with tinderbox (and not with my local make universe), but it
the results might be tainted by my environment somehow.
Thanks!
-Garrett
Index: sys/dev/malo/if_malo.c
===================================================================
--- sys/dev/malo/if_malo.c (revision 221219)
+++ sys/dev/malo/if_malo.c (working copy)
@@ -224,9 +224,9 @@
}
DPRINTF(sc, MALO_DEBUG_FW,
- "malo_hal_gethwspecs: hwversion 0x%x hostif 0x%x"
- "maxnum_wcb 0x%x maxnum_mcaddr 0x%x maxnum_tx_wcb 0x%x"
- "regioncode 0x%x num_antenna 0x%x fw_releasenum 0x%x"
+ "malo_hal_gethwspecs: hwversion 0x%hhx hostif 0x%hhx"
+ "maxnum_wcb 0x%hx maxnum_mcaddr 0x%hx maxnum_tx_wcb 0x%hx"
+ "regioncode 0x%hx num_antenna 0x%hx fw_releasenum 0x%x"
"wcbbase0 0x%x rxdesc_read 0x%x rxdesc_write 0x%x"
"ul_fw_awakecookie 0x%x w[4] = %x %x %x %x",
sc->malo_hwspecs.hwversion,
@@ -1931,7 +1931,8 @@
{
struct ifnet *ifp = sc->malo_ifp;
- if_printf(ifp, "versions [hw %d fw %d.%d.%d.%d] (regioncode %d)\n",
+ if_printf(ifp,
+ "versions [hw 0x%hhx fw %d.%d.%d.%d] (regioncode 0x%hx)\n",
sc->malo_hwspecs.hwversion,
(sc->malo_hwspecs.fw_releasenum >> 24) & 0xff,
(sc->malo_hwspecs.fw_releasenum >> 16) & 0xff,
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
