On Tue, Feb 01, 2011 at 09:18:44AM +0100, Pawel Jakub Dawidek wrote:
> Still, I'm more concerned with CMSG_NXTHDR() macro, which from what I
> see might not be fixed by casting arguments.

Yes, without various checks it expands to
  (struct cmsghdr *)((char *)(cmsg) + \
  _ALIGN(((struct cmsghdr *)(cmsg))->cmsg_len))

Although there is no alignment problem (assuming cmsg is properly
aligned and _ALIGN is correct), this violates -Wcast-align. Therefore I
think an intermediate cast to void * would be appropriate here.

-- 
Jilles Tjoelker
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[email protected]"

Reply via email to