On Fri Nov 19 10, Sergey Kandaurov wrote: > On 19 November 2010 02:14, Alexander Best <[email protected]> wrote: > > hi there, > > > > vfs_mountroot_try() seems to have been removed, yet the src still contains > > three references to it: > > > > vfs_mount.c:386 > > vfs_mount.c:723 > > freebsd32_misc.c:2368 > > > > So, what about just to rename those comments to reflect function name change?
that looks fine. i don't know anything about vfs, so i simply figured out that the reference to vfs_mountroot_try() was not right anymore, but couldn't find where MNT_ROOTFS is now being set. ...so its parse_mount(). :) could you commit that? cheers. alex > > Index: sys/kern/vfs_mount.c > =================================================================== > --- sys/kern/vfs_mount.c (revision 215516) > +++ sys/kern/vfs_mount.c (working copy) > @@ -383,7 +383,7 @@ > * Filter out MNT_ROOTFS. We do not want clients of nmount() in > * userspace to set this flag, but we must filter it out if we want > * MNT_UPDATE on the root file system to work. > - * MNT_ROOTFS should only be set in the kernel in vfs_mountroot_try(). > + * MNT_ROOTFS should only be set in the kernel in parse_mount(). > */ > uap->flags &= ~MNT_ROOTFS; > > @@ -720,7 +720,7 @@ > * Filter out MNT_ROOTFS. We do not want clients of mount() in > * userspace to set this flag, but we must filter it out if we want > * MNT_UPDATE on the root file system to work. > - * MNT_ROOTFS should only be set in the kernel in vfs_mountroot_try(). > + * MNT_ROOTFS should only be set in the kernel in parse_mount(). > */ > uap->flags &= ~MNT_ROOTFS; > > Index: sys/compat/freebsd32/freebsd32_misc.c > =================================================================== > --- sys/compat/freebsd32/freebsd32_misc.c (revision 215516) > +++ sys/compat/freebsd32/freebsd32_misc.c (working copy) > @@ -2365,7 +2365,7 @@ > * Filter out MNT_ROOTFS. We do not want clients of nmount() in > * userspace to set this flag, but we must filter it out if we want > * MNT_UPDATE on the root file system to work. > - * MNT_ROOTFS should only be set in the kernel in vfs_mountroot_try(). > + * MNT_ROOTFS should only be set in the kernel in parse_mount(). > */ > uap->flags &= ~MNT_ROOTFS; > > -- > wbr, > pluknet -- a13x _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "[email protected]"
