On Wed, Oct 20, 2010 at 1:39 PM, Garrett Cooper <[email protected]> wrote: > On Wed, Oct 20, 2010 at 12:45 PM, Peter Jeremy <[email protected]> wrote: >> On 2010-Oct-20 10:50:38 +0400, KOT MATPOCKuH <[email protected]> wrote: >>>> I fixed it with attached patch. >>>Omg... Why You are using strcmp, but not strncmp(fs, "zfs", strlen("zfs"))? >> >> Can you explain why you think it should be strncmp() please. > > I'd say that strcmp is perfectly fine because zfs is a 3 character (4 > if you count NUL) string. The comparison logic is dang near the same:
It wouldn't be about the length of the string, but whether you want a match on other strings like "zfs2", "zfs_foo", and anything else prefixed with zfs. That's the difference between strcmp and strncmp(... strlen()). Thanks, matthew _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "[email protected]"
