Hello,
while tracking down a bug in vesa.c which caused a crash a friend of
mine noticed a potential ressource leak in vesa.c. In line 841 the
execution is aborted via return (1); without freeing the already
allocated resources. the attached patch changes the line to "goto fail;"
which seems more correct.
--- a/sys/dev/fb/vesa.c
+++ b/sys/dev/fb/vesa.c
@@ -836,7 +836,7 @@ vesa_bios_init(void)
"version 1.2 or later is required.\n",
((vers & 0xf000) >> 12) * 10 + ((vers & 0x0f00) >> 8),
((vers & 0x00f0) >> 4) * 10 + (vers & 0x000f));
- return (1);
+ goto fail;
}
VESA_STRCPY(vesa_oemstr, buf->v_oemstr);
--
Homepage: www.yamagi.org
Jabber: yam...@yamagi.org
GnuPG/GPG: 0xEFBCCBCB
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
