Nick Hibma wrote: > > cdevsw_add()
> This should definitely go into attach IMNSHO. > > Probe: Check whether hardware is there (no side effects if possible). > Attach:Get the device up and running and integrated into the kernel. > > With the priority probes this is even more distinct as a priority not > equal to 0 means 'no side effects, just checking'. I've just fixed the bt848 driver (bktr) where the cdevsw_add() was accidentally added to the BSDI bktr_probe() and not the FreeBSD bktr_probe. Although Bruce and Nick said this really belongs, in the _attatch() function, I've kept it in the _probe() function for consistency with all the other drivers. Roger -- Roger Hardiman | Telepresence Research Group ro...@cs.strath.ac.uk | DMEM, University of Strathclyde tel: 0141 548 2897 | Glasgow, Scotland, G1 1XJ, UK fax: 0141 552 0557 | http://telepresence.dmem.strath.ac.uk To Unsubscribe: send mail to majord...@freebsd.org with "unsubscribe freebsd-current" in the body of the message
